[Settings] Add enableSeekDecorrelationFix

Allows disabling the workaround for live playback start (Dash-Industry-Forum#3750)
lkinasiewicz · Sep 7, 2021 · a883dfd · a883dfd
1 parent 5bb6b28
commit a883dfd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/index.d.ts b/index.d.ts
@@ -176,6 +176,7 @@ declare namespace dashjs {
                 keepProtectionMediaKeys?: boolean,
             },
             buffer?: {
+                enableSeekDecorrelationFix?: boolean,
                 fastSwitchEnabled?: boolean,
                 flushBufferAtTrackSwitch?: boolean,
                 reuseExistingSourceBuffers?: boolean,

diff --git a/src/core/Settings.js b/src/core/Settings.js
@@ -84,6 +84,7 @@ import {HTTPRequest} from '../streaming/vo/metrics/HTTPRequest';
  *                keepProtectionMediaKeys: false
  *            },
  *            buffer: {
+                  enableSeekDecorrelationFix: true,
  *                fastSwitchEnabled: true,
  *                flushBufferAtTrackSwitch: false,
  *                reuseExistingSourceBuffers: true,
@@ -239,6 +240,11 @@ import {HTTPRequest} from '../streaming/vo/metrics/HTTPRequest';
 
 /**
  * @typedef {Object} Buffer
+ * @property {boolean} [enableSeekDecorrelationFix=true]
+ * Enables a workaround for playback start on some devices, e.g. WebOS 4.9.
+ * It is necessary because some browsers do not support setting currentTime on video element to a value that is outside of current buffer.
+ *
+ * If you experience unexpected seeking triggered by BufferController, you can try setting this value to false.
  * @property {boolean} [fastSwitchEnabled=true]
  * When enabled, after an ABR up-switch in quality, instead of requesting and appending the next fragment at the end of the current buffer range it is requested and appended closer to the current time.
  *
@@ -761,6 +767,7 @@ function Settings() {
                 keepProtectionMediaKeys: false
             },
             buffer: {
+                enableSeekDecorrelationFix: true,
                 fastSwitchEnabled: true,
                 flushBufferAtTrackSwitch: false,
                 reuseExistingSourceBuffers: true,

diff --git a/src/streaming/controllers/BufferController.js b/src/streaming/controllers/BufferController.js
@@ -346,7 +346,7 @@ function BufferController(config) {
         range = getRangeAt(seekTarget, segmentDuration);
         if (!range) return;
 
-        if (Math.abs(currentTime - seekTarget) > segmentDuration) {
+        if (settings.get().streaming.buffer.enableSeekDecorrelationFix && Math.abs(currentTime - seekTarget) > segmentDuration) {
             // If current video model time is decorrelated from seek target (and appended buffer) then seek video element
             // (in case of live streams on some browsers/devices for which we can't set video element time at unavalaible range)