Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Midi Controller (again) #286

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Add Midi Controller (again) #286

wants to merge 14 commits into from

Conversation

fundale
Copy link
Contributor

@fundale fundale commented Oct 2, 2023

Same as before just resubmitting pr, as I broke the last one...

@pema99
Copy link
Collaborator

pema99 commented Oct 15, 2023

I think this needs some revisiting to be compatible with the new controller, or both if you are interested in that. We hard-forked the old controller when making the new one.

@pema99
Copy link
Collaborator

pema99 commented Dec 9, 2023

I just tested this on my own midi keyboard (Novation Launchkey Mini). The controls were basically unusable. I'm curious, which Midi controller are you using? Perhaps this needs re-mappable controls to really be useful

@fundale
Copy link
Contributor Author

fundale commented Dec 11, 2023

I just tested this on my own midi keyboard (Novation Launchkey Mini). The controls were basically unusable. I'm curious, which Midi controller are you using? Perhaps this needs re-mappable controls to really be useful

Unfortunately I don't have any Physical Midi device, I used Loop-Midi for testing, hence why the inputs are defined in enum.
thinking now might look into defining the enum values in a swappable script

@fundale
Copy link
Contributor Author

fundale commented Dec 14, 2023 •
edited
Loading

TODO: Make tool or scene for easily mapping new layouts

@float3 float3 marked this pull request as draft May 13, 2024 14:39
@float3
Copy link
Collaborator

float3 commented May 13, 2024

marked this as draft, let us know if you want a re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pema99 pema99 pema99 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fundale @pema99 @float3