-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webui.py #2127
Update webui.py #2127
Conversation
Some other users and me have only recently chatted about this exact feature somewhere in the discussions 👍 |
Nice! I am using a reverse proxy to access Fooocus from the outside and are testing with Cloudflare Tunnels and I didn't want unauthenticated access so I tried this modification. Seems to be backwards-compatible, non-breaking. |
IMHO the best case scenario in this case would be to not even route unauthenticated traffic to Fooocus at all but filter it in the reverse proxy. |
For that case it makes senes but let's not discuss that here - it depends a lot on the whole networking setup and how your Ingress / Proxy / NAT setup looks like. The PR is just about allowing basic authentication on Fooocus - one can still decide to move it to the ingress part or not. |
Only enable AuthN for --listen and --share Co-authored-by: Manuel Schmid <[email protected]>
* Update webui.py * Update readme.md * Update webui.py Only enable AuthN for --listen and --share Co-authored-by: Manuel Schmid <[email protected]> * docs: rephrase documentation changes for auth --------- Co-authored-by: Manuel Schmid <[email protected]> Co-authored-by: Manuel Schmid <[email protected]>
Enabling authentication for local and shared UI (--listen and --share), see #2126