Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mistakes in HTML generation #2187

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Fixed mistakes in HTML generation #2187

merged 1 commit into from
Feb 10, 2024

Conversation

V1sionVerse
Copy link
Contributor

@V1sionVerse V1sionVerse commented Feb 6, 2024 •
edited
Loading

Added <!DOCTYPE html> declaration
<img/> instead of <img></img>
<br/> instead of </br>

@V1sionVerse
Fixed mistakes in HTML generation
b17a49f 
Added <!DOCTYPE html> declaration
<img/> instead of <img></img>
<br/> instead of </br>
@V1sionVerse V1sionVerse mentioned this pull request Feb 6, 2024
Closed
mashb1t
mashb1t approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@mashb1t mashb1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍 Let's wait for lllyasviel approval, can't merge it.

@mashb1t mashb1t linked an issue Feb 6, 2024 that may be closed by this pull request
Invalid HTML in private log output #2178
Closed
@mashb1t mashb1t added the Size S small change, basically no testing needed label Feb 8, 2024
@mashb1t mashb1t changed the base branch from main to develop February 10, 2024 16:50
@mashb1t mashb1t merged commit d1a450c into lllyasviel:develop Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalZak17 MichalZak17 MichalZak17 approved these changes

@mashb1t mashb1t mashb1t approved these changes

@lllyasviel lllyasviel Awaiting requested review from lllyasviel lllyasviel is a code owner

Assignees
No one assigned
Labels
Size S small change, basically no testing needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid HTML in private log output
3 participants
@V1sionVerse @mashb1t @MichalZak17