Settings cleanup #2258
Open
Settings cleanup #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashb1t
added
the
Size L
|
@docppp appreciate the effort, thank you very much! There have been a few releases not included in your PR, plus some functionalities are missing, e.g. folder creation if dir does not exist and fallback to default happens as well as output path handling with args. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit in an attempt to refactor config file with the power of attrs library. With this changes, any additional settings are easy to create; user can easily configure every option; presets is parsed same as config.txt; invalid options provided with confix.txt results in fallback to hardcoded in-code defaults.