-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Reads the size and ratio of the image and gives the recommended size #2971
Conversation
xhoxye
commented
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xhoxye thanks for contributing, will check this out in detail in a few hours. Please find one commend attached.
… change default visibility of label
@xhoxye I've applied some adjustments, please check again |
Thank you very much for your help, although it is a little different from what I had in mind at the beginning, I initially wanted to recommend the standard size of SDXL |
@xhoxye thanks for the feedback, that's what i assumed in #2971 (comment) and what makes the most sense. |
Will include it in a few hours. Please add a new PR to develop if you want to be the author, if not i'll just cherry pick from your branch. |
lllyasviel#2971) * Add the information about the size and ratio of the read image * feat: use available aspect ratios from config, move function to util, change default visibility of label * refactor: extract sdxl aspect ratios to flags, use in describe as discussed in lllyasviel#2971 (comment) lllyasviel#2971 (comment) --------- Co-authored-by: Manuel Schmid <[email protected]> Co-authored-by: Manuel Schmid <[email protected]>