Skip to content

Commit

Permalink
Enable maven-shade-plugin #202
Browse files Browse the repository at this point in the history
  • Loading branch information
Olivier B. OURA committed Feb 6, 2021
1 parent 9b0f9fa commit 7cf16c1
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -141,17 +141,7 @@
<version>3.2.4</version>
<executions>
<execution>
<!--
@todo #159:30min This plugin execution was disabled
(phase was set to `package` before) because it prevents
cactoos from actually using cactoos-matchers since the
interfaces provided by cactoos (`Text`, `Func`, `Scalar`, etc)
and those expected by cactoos-matchers do no match!
Let's find a solution to this situation (not shading the
interfaces for example?) and re-enable this plugin. The best
solution should be discussed with ARC in this todo's ticket.
-->
<phase>ignore</phase>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
Expand All @@ -171,6 +161,9 @@
<shadedPattern>
org.llorllale.cactoos.shaded.org.cactoos
</shadedPattern>
<excludes>
<exclude>org.cactoos.*</exclude>
</excludes>
</relocation>
</relocations>
<minimizeJar>true</minimizeJar>
Expand Down

1 comment on commit 7cf16c1

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 7cf16c1 Feb 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 159-5a01dc84 disappeared from pom.xml, that's why I closed #220. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

Please sign in to comment.