Support Scala3 #349

cchantep · 2022-09-05T16:08:22Z

Update the build & CI
Port the EnumMacros and ValueEnumMacros
Refactor coreJVMTests

cchantep · 2022-09-05T16:16:54Z

enumeratum-core-jvm-tests/src/test/scala/enumeratum/EnumJVMSpec.scala

@@ -3,39 +3,5 @@ package enumeratum
 import org.scalatest.funspec.AnyFunSpec
 import org.scalatest.matchers.should.Matchers

-class EnumJVMSpec extends AnyFunSpec with Matchers {


Refactor tests based call to compiler (not portable accross Scala version) with SBT code generation (portable and somewhat safer)

cchantep · 2022-09-05T16:18:20Z

enumeratum-core-jvm-tests/src/test/scala/enumeratum/Eval.scala

@@ -1,25 +0,0 @@
-package enumeratum


Replaced by SBT code generation

cchantep · 2022-09-05T16:19:00Z

enumeratum-core-jvm-tests/src/test/scala/enumeratum/values/ValueEnumJVMSpec.scala

 /** Created by Lloyd on 8/30/16.
  *
  * Copyright 2016
  */
-class ValueEnumJVMSpec extends AnyFunSpec with Matchers {


Refactor call to compiler (not portable) using SBT code generation

cchantep · 2022-09-05T20:49:32Z

.github/workflows/ci.yml

              sbt -v ++${{ matrix.scala }} test:compile test:doc
              sbt -v ++${{ matrix.scala }} test
              ;;
-            *)


No need to fail there, SBT will anyway check whether the version selected by the CI is supported (and it avoid to hard code more cases)

cchantep · 2022-09-05T20:52:04Z

enumeratum-core/src/main/scala-2/enumeratum/EnumCompat.scala

+
+import scala.language.experimental.macros
+
+private[enumeratum] trait EnumCompat[A <: EnumEntry] { _: Enum[A] =>


Cross-version compatibility trait for Enum[A], mainly due to macro migration

cchantep · 2022-09-05T20:53:00Z

enumeratum-core/src/main/scala/enumeratum/Enum.scala

@@ -62,23 +61,16 @@ trait Enum[A <: EnumEntry] {
    */
  lazy final val valuesToIndex: Map[A, Int] = values.zipWithIndex.toMap

-  /** The sequence of values for your [[Enum]]. You will typically want to implement this in your


Moved to the EnumCompat cross-version compatibility trait

cchantep · 2022-09-05T20:59:08Z

enumeratum-core/src/main/scala/enumeratum/values/ValueEnum.scala

@@ -80,79 +75,25 @@ sealed trait ValueEnum[ValueType, EntryType <: ValueEnumEntry[ValueType]] {
 * and macro invocations cannot provide implementations for a super class's abstract method
 */

-object IntEnum {


Moved to the cross-version compatibility trait IntEnumCompanion

cchantep · 2022-09-05T20:59:38Z

enumeratum-core/src/main/scala/enumeratum/values/ValueEnum.scala


-  /** Method that returns a Seq of [[A]] objects that the macro was able to find.


Moved to the cross-version compatibility trait LongEnumCompat

cchantep · 2022-09-05T22:00:18Z

build.sbt

    case _ =>
-      throw new IllegalArgumentException(s"Unsupported Scala version $scalaVersion")
+      throw new IllegalArgumentException(s"Unsupported Scala version $scalaVersion for Doobie")


Better error message

cchantep · 2022-09-05T22:01:42Z

build.sbt

-lazy val coreJS  = core.js
-lazy val coreJVM = core.jvm
+
+def configureWithLocal(m: Project): Project => Project = { p =>


Utility to use local project/dependency rather than stable/previous version dependency

cchantep · 2022-09-05T22:02:40Z

project/CoreJVMTest.scala

+        IO.writer[Seq[File]](ef, "", IO.defaultCharset, false) { w1 =>
+          // Generate enum file
+
+          w1.append(s"""package generated


Generate an Enum per each iteration

cchantep · 2022-09-05T22:02:51Z

project/CoreJVMTest.scala

+
+            w2.append(s"""package generated
+
+trait ${enumName}Test { _spec: EnumBaseSpec with enumeratum.EnumJVMSpec =>


Generate associated test trait

cchantep · 2022-09-05T22:03:03Z

project/CoreJVMTest.scala

+
+  // ---
+
+  private def generateValueEnumTest[A](


Same for ValueEnum

cchantep · 2022-09-06T19:25:04Z

enumeratum-test/src/main/scala/enumeratum/values/Alphabet.scala

@@ -1,18 +0,0 @@
-package enumeratum.values


No need to duplicate those fixtures, rather provide them from coreX % "compile->compile;test->test" as they are already used in tests there

cchantep · 2022-09-06T21:09:23Z

build.sbt

  )

 lazy val macrosJS  = macros.js
 lazy val macrosJVM = macros.jvm

+lazy val useLocalVersion = sys.props.get("enumeratum.useLocalVersion").nonEmpty


Flag not to try to use a previous stable version

cchantep · 2022-09-06T21:10:36Z

build.sbt

+      val dep = "org.scalatest" %%% "scalatest" % scalaTestVersion % Test
+
+      if (scalaBinaryVersion.value == "3") {
+        dep.exclude("org.scala-lang.modules", "*")


Avoid conflict when mixing Scala2.13/3 for compatibility

codecov-commenter · 2022-09-07T11:40:41Z

Codecov Report

Merging #349 (f826d23) into master (e61f1b6) will decrease coverage by 4.60%.
The diff coverage is 92.24%.

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   90.37%   85.76%   -4.61%     
==========================================
  Files          63       63              
  Lines         530      527       -3     
  Branches        8       24      +16     
==========================================
- Hits          479      452      -27     
- Misses         51       75      +24

Impacted Files	Coverage Δ
...in/scala/enumeratum/values/ArgonautValueEnum.scala	`100.00% <ø> (ø)`
...umeratum-core/src/main/scala/enumeratum/Enum.scala	`100.00% <ø> (ø)`
...e/src/main/scala/enumeratum/values/ValueEnum.scala	`100.00% <ø> (ø)`
...atum-json4s/src/main/scala/enumeratum/Json4s.scala	`100.00% <ø> (ø)`
...on4s/src/main/scala/enumeratum/values/Json4s.scala	`100.00% <ø> (ø)`
...in/scala/enumeratum/values/PlayFormValueEnum.scala	`100.00% <ø> (ø)`
...eratum-quill/src/main/scala/enumeratum/Quill.scala	`0.00% <0.00%> (ø)`
...quill/src/main/scala/enumeratum/values/Quill.scala	`0.00% <0.00%> (ø)`
.../main/scala/enumeratum/values/QuillValueEnum.scala	`0.00% <0.00%> (ø)`
...enumeratum/values/ReactiveMongoBsonValueEnum.scala	`33.33% <ø> (ø)`
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cchantep · 2022-09-07T11:33:38Z

.github/workflows/ci.yml

@@ -13,15 +13,18 @@ jobs:
          - java: 11
            scala: 2.11.12
          - java: 11
-            scala: 2.12.14


Update covered scala versions

cchantep · 2022-09-07T11:33:53Z

build.sbt

-lazy val scala_2_12Version = "2.12.14"
-lazy val scala_2_13Version = "2.13.6"
-lazy val scalaVersionsAll  = Seq(scala_2_11Version, scala_2_12Version, scala_2_13Version)
+lazy val scala_2_12Version = "2.12.16"


Update covered scala versions

cchantep · 2022-09-07T11:40:30Z

build.sbt

-    aggregate in publish               := false,
-    aggregate in PgpKeys.publishSigned := false
+    // doctestWithDependencies := false, // sbt-doctest is not yet compatible with this 2.13
+    publish / aggregate               := false,


Fix deprecated syntax

cchantep · 2022-09-07T11:40:47Z

build.sbt

  .settings(
-    version            := "1.7.1-SNAPSHOT",
+    version            := Versions.Core.head,


Align versions

cchantep · 2022-09-07T11:41:21Z

enumeratum-scalacheck/src/main/scala/enumeratum/ArbitraryInstances.scala

@@ -5,7 +5,7 @@ import org.scalacheck.{Arbitrary, Gen}
 trait ArbitraryInstances {

  implicit def arbEnumEntry[EnumType <: EnumEntry](implicit
-      enum: Enum[EnumType]


Avoid enum naming

cchantep · 2022-09-07T18:35:27Z

enumeratum-reactivemongo-bson/src/main/scala/enumeratum/EnumHandler.scala

@@ -15,65 +15,73 @@ object EnumHandler {

  /** Returns a BSONReader for a given enum [[Enum]]
    *
-    * @param enum


Avoid reversed keyword enum as naming

cchantep · 2022-09-07T18:35:33Z

enumeratum-reactivemongo-bson/src/main/scala/enumeratum/values/EnumHandler.scala

@@ -12,29 +12,29 @@ object EnumHandler {
    * Enum's value type.
    */
  def reader[ValueType, EntryType <: ValueEnumEntry[ValueType]](
-      enum: ValueEnum[ValueType, EntryType]
+      @deprecatedName(Symbol("enum")) e: ValueEnum[ValueType, EntryType]


Avoid reversed keyword enum as naming

cchantep · 2022-09-07T18:35:43Z

enumeratum-reactivemongo-bson/src/main/scala/enumeratum/values/ReactiveMongoBsonValueEnum.scala


 /** @author
  *   Alessandro Lacava (@lambdista)
  * @since 2016-04-23
  */
 sealed trait ReactiveMongoBsonValueEnum[ValueType, EntryType <: ValueEnumEntry[ValueType]] {
-  enum: ValueEnum[ValueType, EntryType] =>
+  selfEnum: ValueEnum[ValueType, EntryType] =>


Avoid reversed keyword enum as naming

cchantep · 2022-09-07T18:36:36Z

...eratum-reactivemongo-bson/src/test/scala/enumeratum/values/ValueEnumBsonHandlerHelpers.scala


 /** @author
  *   Alessandro Lacava (@lambdista)
  * @since 2016-04-23
  */
-trait EnumBsonHandlerHelpers { this: AnyFunSpec with Matchers =>
+trait ValueEnumBsonHandlerHelpers { this: AnyFunSpec with Matchers =>


Avoid EnumBsonHandlerHelpers in several packages (misleading error messages)

cchantep · 2022-09-07T18:36:45Z

...eratum-reactivemongo-bson/src/test/scala/enumeratum/values/ValueEnumBsonHandlerHelpers.scala


  def testWriter[EntryType <: ValueEnumEntry[ValueType], ValueType](
      enumKind: String,
-      enum: ValueEnum[ValueType, EntryType],


Avoid reversed keyword enum as naming

cchantep · 2022-09-07T21:42:55Z

enumeratum-quill/src/test/scala/enumeratum/QuillEnumSpec.scala

-        | import ctx._
-        | ctx.run(query[QuillShirt].insert(_.size -> lift(QuillShirtSize.Small: QuillShirtSize)))
-      """.stripMargin should compile
+import io.getquill._


Only string literal is supported by should compile

cchantep · 2022-09-07T21:43:24Z

project/plugins.sbt

-addSbtPlugin("com.github.tkawachi" % "sbt-doctest"              % "0.9.9")
-addSbtPlugin("com.jsuereth"        % "sbt-pgp"                  % "1.1.2")
-addSbtPlugin("com.eed3si9n"        % "sbt-buildinfo"            % "0.9.0")
+resolvers += Classpaths.sbtPluginReleases


Update plugins

cchantep · 2022-09-08T20:52:59Z

enumeratum-slick/src/main/scala/enumeratum/SlickEnumColumnSupport.scala


  def mappedColumnTypeForEnum[E <: EnumEntry](
-      enum: Enum[E]
+      @deprecatedName(Symbol("enum")) e: Enum[E]


Slick not yet ready, but prepare this code for a further migration

lloydmeta

Just finished reviewing the Quill, Reactive,and Slick-related changes; those all LGTM. Next round will be looking at the Scala3 macro-code, which at a glance looks quite good.

Again, apologies for the slow/intermittent process here 🙇‍♂️

mushtaq · 2022-11-23T10:21:13Z

This is one of the most important PR that unblocks our projects for scala-3 migration

Thanks @cchantep and @lloydmeta for all the work 👍 !

lloydmeta

Finally finished making my way through. Overall, LGTM

@cchantep I had a few questions about the TODOs still in the Scala 3 code that I would love your input on. My main concern there would be whether or not they are really todos and what the consequences are for leaving them as TODOs.

lloydmeta · 2022-11-26T04:39:11Z

macros/src/main/scala-3/enumeratum/EnumMacros.scala

+  )(using tpe: Type[T]): List[q.reflect.TypeRepr] = {
+    import q.reflect.*
+
+    // TODO: Use SumOf?


@cchantep can you please shed some light on this todo?

lloydmeta · 2022-11-26T04:44:34Z

macros/src/main/scala-3/enumeratum/EnumMacros.scala

+          child.asType match {
+            case '[IsEntry[t]] => {
+              val tpeSym = child.typeSymbol
+              // TODO: Check is subtype (same in Scala2?)


@cchantep :c

Curious if this is already verified by the type match + compiler because of the type alias above of IsEntry[E <: T]?

lloydmeta · 2022-11-26T04:45:46Z

macros/src/main/scala-3/enumeratum/EnumMacros.scala

+
+    tpr.classSymbol
+      .flatMap { cls =>
+        // TODO: cls.typeMembers


@cchantep is this todo still valid?

lloydmeta · 2022-11-26T04:48:11Z

macros/src/main/scala-3/enumeratum/ValueEnumMacros.scala

+
+    import q.reflect.*
+
+    val ctx = q.asInstanceOf[scala.quoted.runtime.impl.QuotesImpl].ctx


Would a pattern match on the type and report.errorAndAbort if not the expected class be nicer here?

I don't see what you mean.
As indicated thereafter (L125), the settings must be check to be sure the tree can be inspected.

lloydmeta · 2022-11-26T04:50:52Z

macros/src/main/scala-3/enumeratum/ValueEnumMacros.scala

+              val moduleField = cls.getFields.find(_.getName == f"MODULE$$")
+
+              moduleField.map { field =>
+                new ValueOf(field.get(null).asInstanceOf[T])


field.get(null).asInstanceOf[T] is interesting; @cchantep can you please shed some light on this?

Ultimately this is could just be my ignorance of the Scala3 macro world, but it's odd to see two "Scala taboos" consecutively.

There is not metaprogramming, it's low level reflection, as current metaprogramming doesn't cover such case.

mushtaq · 2022-11-26T05:41:38Z

Finally finished making my way through. Overall, LGTM

I was testing this PR to see if I can migrate my existing usage of enumeratum to the scala-3 version and I found a few issues. I will try to post them in separate comments below. @cchantep @lloydmeta

mushtaq · 2022-11-26T05:43:34Z

Issue-1

//> using scala "3.2.1"
//> using repository "jitpack"
//> using lib "com.github.mushtaq.enumeratum::enumeratum:be1c8d6"

import enumeratum.{Enum, EnumEntry}
import scala.collection.immutable

sealed trait Base extends EnumEntry

class Derived extends Base

object Base extends Enum[Base] {
  override def values: immutable.IndexedSeq[Base] = findValues // error in compilation

  case object E1 extends Base
  case object E2  extends Base
}

mushtaq · 2022-11-26T05:44:18Z

Issue-2

//> using scala "3.2.1"
//> using repository "jitpack"
//> using lib "com.github.mushtaq.enumeratum::enumeratum:be1c8d6"


import enumeratum.{Enum, EnumEntry}
import scala.collection.immutable

sealed trait Base extends EnumEntry

object Base extends Enum[Base] {
  class Derived extends Base

  override def values: immutable.IndexedSeq[Base] = findValues

  case object E1 extends Derived
  case object E2  extends Derived
}

object Demo {
  def main(args: Array[String]): Unit = {
    println(Base.values) // prints empty vector
  }
}

mushtaq · 2022-11-26T05:48:34Z

These are self contained scala-cli scripts which work with scala 2.13 and current published version of enumeratum.

The artifact referred in the script is jitpack published from a fork of this PR

cchantep · 2022-11-26T13:39:24Z

@mushtaq Cannot reproduce Issue 1, check your env.

Issue 1:

sbt:enumeratum> console
Welcome to Scala 3.2.1-RC1 (9.0.1, Java Java HotSpot(TM) 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.
                                                                                                                            
scala> :paste
Unknown command: ":paste", run ":help" for a list of commands
                                                                                                                            
scala> import enumeratum.{Enum, EnumEntry}
     | import scala.collection.immutable
     | 
     | sealed trait Base extends EnumEntry
     | 
     | class Derived extends Base
     | 
     | object Base extends Enum[Base] {
     |   override def values: immutable.IndexedSeq[Base] = findValues // error in compilation
     | 
     |   case object E1 extends Base
     |   case object E2  extends Base
     | }
// defined trait Base
// defined class Derived
// defined object Base
                                                                                                                            
scala> 
                                                                                                                            
scala> Base.values
val res0: IndexedSeq[Base] = Vector(E1, E2)

mushtaq · 2022-11-26T13:55:32Z

@cchantep Have you tried putting the test in .scala file?

Using either REPL or a .sc file will not reproduce the issue.

To make it easy, I put the issues in gists. You can run them like so:

$ scala-cli https://gist.github.com/mushtaq/16705977494d73a3d921f53ffe5c7a32

Compiling project (Scala 3.2.1, JVM)
[error] 16705977494d73a3d921f53ffe5c7a32-main/issue1.scala:13:53: 
The enum (i.e. the class containing the case objects and the call to `findValues`) must be an object
Error compiling project (Scala 3.2.1, JVM)
Compilation failed


$ scala-cli https://gist.github.com/mushtaq/d643b306e22464ab13e637d3971da3aa

Vector()

cchantep · 2022-11-26T18:26:24Z

@mushtaq In REPL or in a .scala file, in SBT the issue 1 is not reproducible.

mushtaq · 2022-11-27T03:04:18Z

Interesting!

I am Scala 3.2.1 with Java-17 on MacOS. Maybe something to do with that combination.

Can you please share what is the output of this command on your machine:

$ scala-cli https://gist.github.com/mushtaq/16705977494d73a3d921f53ffe5c7a32

cchantep · 2022-11-27T14:00:26Z

@mushtaq Rather test it SBT/Scala REPL.
For me, the use in scala-cli is not a priority, and maybe related to Scala 3 support by scala-cli (so out of scope). You can eventually create a separate issue, after more investigation.

cchantep · 2022-11-27T14:34:33Z

Issue 2 is fine:

mushtaq · 2022-11-27T15:59:38Z

Issue 2 is fine:

Thanks!

mushtaq · 2022-11-27T16:05:31Z

@mushtaq Rather test it SBT/Scala REPL.

Sure, here is the github repo with sbt to reproduce the issue-1.

sbt compile fails with the same message:

[error] -- Error: /Users/mushtaqahmed/projects/scala3/enumeraturm-compilation-issue/src/main/scala/Main.scala:9:52
[error] 9 |  override def values: immutable.IndexedSeq[Base] = findValues // error in compilation
[error]   |                                                    ^^^^^^^^^^
[error]   |The enum (i.e. the class containing the case objects and the call to `findValues`) must be an object

cchantep · 2022-11-27T19:45:03Z

Issue-1 is fine

mushtaq · 2022-11-28T14:30:24Z

Issue-1 is fine

I published and verified both issues with your changes.
Issue-1 is indeed fixed, thank you @cchantep !

Unfortunately, issue-2 is yet not fixed.
If you take a pull from the sbt repo and run sbt 'runMain issue2.Demo', it still prints Vector() 😔

cchantep · 2022-11-28T15:06:44Z

@mushtaq Issue is fixed and covered by the indicated test

mushtaq · 2022-11-28T17:28:05Z

enumeratum-core/src/test/scala/enumeratum/Models.scala

+  sealed trait Word extends EnumEntry
+
+  object Word extends Enum[Word] {
+    sealed class Greeting extends Word


If you remove sealed from class Greeting, the test will fail

@cchantep Notice that class Derived is not sealed in my example.

To reproduce the issue-1, you should remove sealed from class Greeting.

Not having sealed cannot (and should not) be supported

It works perfectly well with scala-2.13 and enumeraturm 1.7.0 as shown in this gist:

$ scala-cli https://gist.github.com/mushtaq/5055834b968bf17c84bfa28f36980924 Compiling project (Scala 2.13.10, JVM) Compiled project (Scala 2.13.10, JVM) Vector(E1, E2)

Note that Base is still sealed.

Derived does not require to be sealed, because we are creating an Enum[Base] and not an Enum[Derived]

@mushtaq That it works with 2.13 doesn't give it more sense.

You may be lucky that Scala 2.13 find subobjects, but it has always add limitation for the macros to find subtypes.

Such modeling looks like an edge one for me that I would not encourage, and even prevent and detect as erroneous.

I won't take more time on such case, so feel free to block this PR and close it.

@cchantep I would love this PR to be merged ASAP because it is so useful to have enumeratum on scala-3.

The issues pointed out here are not blockers because I already have found workarounds.

I am sharing them just so that you or @lloydmeta may want to make use of them!

Thanks a lot once again for your responsiveness 👍

Signed-off-by: lloydmeta <[email protected]>

Signed-off-by: Lloyd <[email protected]>

lloydmeta

LGTM.

cchantep commented Sep 5, 2022

View reviewed changes

cchantep force-pushed the task/scala3 branch from fc58621 to e539a9f Compare September 5, 2022 20:48

EnumMacros

9636290

cchantep force-pushed the task/scala3 branch from e539a9f to 4ebb5cf Compare September 5, 2022 20:57

ValueEnumMacros

201247d

cchantep force-pushed the task/scala3 branch from 4ebb5cf to a3f9386 Compare September 5, 2022 21:13

Update coreJVMTests

d7d07ac

cchantep force-pushed the task/scala3 branch from a3f9386 to d7d07ac Compare September 5, 2022 21:59

cchantep commented Sep 5, 2022

View reviewed changes

Update build & tests

9dc1974

cchantep force-pushed the task/scala3 branch 3 times, most recently from defd7f6 to b857103 Compare September 6, 2022 21:08

cchantep commented Sep 6, 2022

View reviewed changes

cchantep force-pushed the task/scala3 branch from b857103 to e91a56b Compare September 7, 2022 11:32

Fix scalacheck for Scala 3

94a2589

cchantep force-pushed the task/scala3 branch from e91a56b to 94a2589 Compare September 7, 2022 11:39

Update more modules for Scala3 compatibility

1a8942b

cchantep commented Sep 7, 2022

View reviewed changes

cchantep added 2 commits September 7, 2022 22:55

Update play modules

51e8f84

Update doobie/quill

e96bf14

cchantep commented Sep 7, 2022

View reviewed changes

cchantep added 3 commits September 8, 2022 10:40

Fix

ba6803b

Disable Slick

44d1fd3

Disable JSON4S

c907f6c

cchantep commented Sep 8, 2022

View reviewed changes

Fix test dependencies

bb5e42e

cchantep force-pushed the task/scala3 branch from 85ff7bd to bb5e42e Compare September 8, 2022 21:00

cchantep marked this pull request as ready for review September 8, 2022 22:37

Review

79aeb2a

lloydmeta mentioned this pull request Nov 3, 2022

Scala 3: What should be done #300

Closed

lloydmeta reviewed Nov 13, 2022

View reviewed changes

lloydmeta reviewed Nov 26, 2022

View reviewed changes

cchantep force-pushed the task/scala3 branch 2 times, most recently from 219a8ca to bf8f4fe Compare November 27, 2022 15:06

Review & rebase

ee55e85

cchantep force-pushed the task/scala3 branch from bf8f4fe to ee55e85 Compare November 27, 2022 19:15

mushtaq reviewed Nov 28, 2022

View reviewed changes

lloydmeta added 2 commits December 3, 2022 22:20

* Use match instead of straight cast

3ae11c4

Signed-off-by: lloydmeta <[email protected]>

Add Scala3 mention in Readme

f826d23

Signed-off-by: Lloyd <[email protected]>

lloydmeta approved these changes Dec 3, 2022

View reviewed changes

lloydmeta merged commit 6ac99af into lloydmeta:master Dec 3, 2022

cchantep deleted the task/scala3 branch December 3, 2022 18:33


		import scala.language.experimental.macros

		private[enumeratum] trait EnumCompat[A <: EnumEntry] { _: Enum[A] =>


		/** Method that returns a Seq of [[A]] objects that the macro was able to find.


		w2.append(s"""package generated

		trait ${enumName}Test { _spec: EnumBaseSpec with enumeratum.EnumJVMSpec =>


		import q.reflect.*

		val ctx = q.asInstanceOf[scala.quoted.runtime.impl.QuotesImpl].ctx

Support Scala3 #349

Support Scala3 #349

Conversation

cchantep commented Sep 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Sep 7, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lloydmeta left a comment

Choose a reason for hiding this comment

mushtaq commented Nov 23, 2022

lloydmeta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mushtaq commented Nov 26, 2022 • edited Loading

mushtaq commented Nov 26, 2022 • edited Loading

Issue-1

mushtaq commented Nov 26, 2022

Issue-2

mushtaq commented Nov 26, 2022

cchantep commented Nov 26, 2022

mushtaq commented Nov 26, 2022

cchantep commented Nov 26, 2022 • edited Loading

mushtaq commented Nov 27, 2022

cchantep commented Nov 27, 2022 • edited Loading

cchantep commented Nov 27, 2022

mushtaq commented Nov 27, 2022

mushtaq commented Nov 27, 2022

cchantep commented Nov 27, 2022

mushtaq commented Nov 28, 2022

cchantep commented Nov 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lloydmeta left a comment

Choose a reason for hiding this comment

codecov-commenter commented Sep 7, 2022 •

edited

Loading

mushtaq commented Nov 26, 2022 •

edited

Loading

mushtaq commented Nov 26, 2022 •

edited

Loading

cchantep commented Nov 26, 2022 •

edited

Loading

cchantep commented Nov 27, 2022 •

edited

Loading