[Arc] Partially enable reset/enable detection #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the `InferStateProperties` pass in the arcilator pipeline and make its enable and reset signal detection individually controllable. The enable portion is already supported by the rest of the arcilator pipeline and can produce 20%-35% speedup on the cores in arc-tests.Turn on enable detection by default. The reset portion is not fully supported yet and causes the simulation to misbehave. It is disabled by default. As a minor refactoring this removes the `constructor` field from the pass definition, such that the constructor and plumbing for options gets generated automatically. As a side effect, the constructor is now called `arc::createInferStateProperties` instead of the previous `arc::createInferStatePropertiesPass`. (Thanks @uenoku for the pointer.) Shoutout to @maerhart and @TaoBi22 for this fantastic pass!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
InferStatePropertiespass in the arcilator pipeline and make its enable and reset signal detection individually controllable. The enable portion is already supported by the rest of the arcilator pipeline and can produce 20%-35% speedup on the cores in arc-tests.Turn on enable detection by default.The reset portion is not fully supported yet and causes the simulation to misbehave. It is disabled by default.
As a minor refactoring this removes the
constructorfield from the pass definition, such that the constructor and plumbing for options gets generated automatically. As a side effect, the constructor is now calledarc::createInferStatePropertiesinstead of the previousarc::createInferStatePropertiesPass. (Thanks @uenoku for the pointer.)Shoutout to @maerhart and @TaoBi22 for this fantastic pass!