[Debug] Add inline scope support to HGLDD emission #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
approved these changes
Dec 12, 2023
lib/Target/DebugInfo/EmitHGLDD.cpp
Outdated
Comment on lines
553
to
556
| } | ||
|
|
||
| // Emit the module name (HGL and HDL), unless this is an inline scope. | ||
| if (!instance->module->isInline) { |
There was a problem hiding this comment.
Any reason this if block cannot be pulled into the last one ? Looks like same condition.
There was a problem hiding this comment.
Oh yeah thanks for catching this. 🙈
Emit inline levels of hierarchy in the DI, introduced by the new `dbg.scope` operation, as inline module definitions. This is explicitly supported in HGLDD in order to represent inlined modules in the debug info as if they were still present. Language frontends may also choose to emit additional scope ops to represent lexical scopes, call stacks, and other source language constructs in the debug info. HGLDD will accurately represent these.
fabianschuiki
force-pushed
the
fschuiki/hgldd-inline-scopes
branch
from
b2dc565
to
f6ab133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit inline levels of hierarchy in the DI, introduced by the new
dbg.scopeoperation, as inline module definitions. This is explicitly supported in HGLDD in order to represent inlined modules in the debug info as if they were still present. Language frontends may also choose to emit additional scope ops to represent lexical scopes, call stacks, and other source language constructs in the debug info. HGLDD will accurately represent these.