-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OM] Rework ClassOp to use fields terminator #7537
Open
leonardt
wants to merge
27
commits into
main
Choose a base branch
from
lenny/fix-7078-squashed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 27, 2024
-
[OM] Rework ClassLike to use return style
This changes the OM dialect Class/ExternClass to use a return style field name/type specifier syntax and, for non-extern class, a terminator op in the style of hw.output. The ClassLike code requires updating their parser/printer for the new syntax. This change introduces two new inherent attributes for ClassLike: * fieldNames: array of string attribute corresponding to field names in definition order * fieldTypes: dictionary mapping field names to types The ClassLike code now provides an API to get the type of a field based on its name, abstracting the underlying attribute storage. The firrtl LowerClasses logic requires changes to use this API when constructing OM classes, as well as in the dialect conversion logic to handle the convering the stored types. The OM evaluator similarly is updated for the new field API. The OM linker is updated to skip constructing the field name to type map and instead using the getFieldType API provided by the classOp. The OM object field verifier also no longer needs to construct the field name to type maps and instead can just use the new API. Quite a few tests required updating for the new field syntax.
Configuration menu - View commit details
-
Copy full SHA for cbf9f5f - Browse repository at this point
Copy the full SHA cbf9f5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4bdd0c - Browse repository at this point
Copy the full SHA f4bdd0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71f8ae0 - Browse repository at this point
Copy the full SHA 71f8ae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f02555f - Browse repository at this point
Copy the full SHA f02555fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8f2aa5 - Browse repository at this point
Copy the full SHA f8f2aa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cc1518 - Browse repository at this point
Copy the full SHA 4cc1518View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9001f6a - Browse repository at this point
Copy the full SHA 9001f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f55fd57 - Browse repository at this point
Copy the full SHA f55fd57View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3d6fc3 - Browse repository at this point
Copy the full SHA d3d6fc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 095834e - Browse repository at this point
Copy the full SHA 095834eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92960ed - Browse repository at this point
Copy the full SHA 92960edView commit details -
Configuration menu - View commit details
-
Copy full SHA for b789627 - Browse repository at this point
Copy the full SHA b789627View commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 85e6d6a - Browse repository at this point
Copy the full SHA 85e6d6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd7ff80 - Browse repository at this point
Copy the full SHA dd7ff80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cf7849 - Browse repository at this point
Copy the full SHA 4cf7849View commit details -
Configuration menu - View commit details
-
Copy full SHA for c46abb8 - Browse repository at this point
Copy the full SHA c46abb8View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1c84f9e - Browse repository at this point
Copy the full SHA 1c84f9eView commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e6ad898 - Browse repository at this point
Copy the full SHA e6ad898View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38549a0 - Browse repository at this point
Copy the full SHA 38549a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66f440b - Browse repository at this point
Copy the full SHA 66f440bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7137630 - Browse repository at this point
Copy the full SHA 7137630View commit details -
Revert "Test appending _in to ports input"
This reverts commit 38549a0.
Configuration menu - View commit details
-
Copy full SHA for 4becb61 - Browse repository at this point
Copy the full SHA 4becb61View commit details
Commits on Oct 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65948a3 - Browse repository at this point
Copy the full SHA 65948a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9226a5d - Browse repository at this point
Copy the full SHA 9226a5dView commit details -
Revert "Use map vector to preserve field name ordering"
This reverts commit 9226a5d.
Configuration menu - View commit details
-
Copy full SHA for e7cb5e7 - Browse repository at this point
Copy the full SHA e7cb5e7View commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1b9ff8 - Browse repository at this point
Copy the full SHA d1b9ff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d3b799 - Browse repository at this point
Copy the full SHA 8d3b799View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.