[FIRRTL] Print port names attributes if a port has an empty name #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a port name is empty, then the SSA-name cannot match, and we must print the port names as an attribute instead. This PR removes a bogus check in the module printer, which prevents us from printing the port names attribute, if the port name is empty.
With this PR, modules with empty port names should round trip correctly.
When lower-layers converts layerblocks into modules, a lot of the time there is no good name for the port, so it generates an empty port name. With this patch, these modules will now correctly print the port names attribute, so the tests had to be updated to match against the attribute dictionary.
Fixes: #7224