[FIRRTL] Ensure LowerClasses respects alt base path for local paths. #7690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently started supporting local-only paths in LowerClasses, but this logic erroneously disabled the alternative base path feature for paths whose targets were relocated outside the owning module. In the case that we need an alternative base path for a local target, convert it to a non-local target, so the alternative base path can be correctly prefixed.
|
Needs a unit test or two, but I have been testing this downstream and I think it's correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started supporting local-only paths in LowerClasses, but this logic erroneously disabled the alternative base path feature for paths whose targets were relocated outside the owning module. In the case that we need an alternative base path for a local target, convert it to a non-local target, so the alternative base path can be correctly prefixed.