[ArcToLLVM] Add support for index dialect #7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
approved these changes
Oct 14, 2024
| @@ -440,20 +441,19 @@ struct SimGetPortOpLowering : public ModelAwarePattern<arc::SimGetPortOp> { | |||
| .getValue()); | |||
| ModelInfoMap &model = modelIt->second; | |||
|
|
|||
| auto type = typeConverter->convertType(op.getValue().getType()); | |||
There was a problem hiding this comment.
Nit: We don't specifically restrict the type of arc model ports, right? So maybe we should check for null type here and return failure? Or at least assert?
There was a problem hiding this comment.
Good point! Fixed
Support the index dialect when lowering from Arc to LLVM. Also fix a minor issue in the lowering `SimGetPortOp`.
fabianschuiki
force-pushed
the
fschuiki/arcilator-index
branch
from
2a8231b
to
6b4e7a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the index dialect when lowering from Arc to LLVM. Also fix a minor issue in the lowering
SimGetPortOp.