Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dsymutil] return EXIT_FAILURE when Crashed #106619

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

rmaz
Copy link
Contributor

@rmaz rmaz commented Aug 29, 2024

Make dsymutil return a non-zero exit code when crashing during linking.

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 29, 2024

@llvm/pr-subscribers-debuginfo

Author: Richard Howell (rmaz)

Changes

Make dsymutil return a non-zero exit code when crashing during linking.


Full diff: https://github.com/llvm/llvm-project/pull/106619.diff

1 Files Affected:

  • (modified) llvm/tools/dsymutil/dsymutil.cpp (+1-1)
diff --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp
index 728f2ed3e62aca..364a7d63d486e1 100644
--- a/llvm/tools/dsymutil/dsymutil.cpp
+++ b/llvm/tools/dsymutil/dsymutil.cpp
@@ -835,7 +835,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
     if (Crashed)
       (*Repro)->generate();
 
-    if (!AllOK)
+    if (!AllOK || Crashed)
       return EXIT_FAILURE;
 
     if (NeedsTempFiles) {

@rmaz rmaz requested review from drodriguez and JDevlieghere and removed request for JDevlieghere August 29, 2024 19:43
@rmaz rmaz merged commit 2d5613a into llvm:main Aug 30, 2024
10 checks passed
@rmaz rmaz deleted the dsymutil_crash branch August 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants