Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Use references to avoid copying #110462

Closed
wants to merge 8 commits into from
Closed

[NFC] Use references to avoid copying #110462

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f01499
[NFC] Use references to avoid copying
pratyay-p Sep 30, 2024
d2d2b51
Merge remote-tracking branch 'refs/remotes/origin/main'
pratyay-p Sep 30, 2024
59dcac3
Merge branch 'llvm:main' into main
pratyay-p Sep 30, 2024
a6e6e75
Removing reference as enumerate returns a ref.
pratyay-p Sep 30, 2024
9c35706
Fixed clang-format issues
pratyay-p Sep 30, 2024
17808e7
Merge branch 'main' into main
pratyay-p Oct 17, 2024
138f49b
Merge branch 'llvm:main' into main
pratyay-p Oct 17, 2024
b835728
Update IntrinsicEmitter.cpp
pratyay-p Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/utils/TableGen/IntrinsicEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ void IntrinsicEmitter::EmitIntrinsicToOverloadTable(
static constexpr uint8_t OTable[] = {
0
)";
for (auto [I, Int] : enumerate(Ints)) {
for (const auto [I, Int] : enumerate(Ints)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it is just a copy, do we still need const?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed const

// Add one to the index so we emit a null bit for the invalid #0 intrinsic.
size_t Idx = I + 1;

Expand Down Expand Up @@ -346,7 +346,7 @@ static constexpr {} IIT_Table[] = {{
FixedEncodingTypeName);

unsigned MaxOffset = 0;
for (auto [Idx, FixedEncoding, Int] : enumerate(FixedEncodings, Ints)) {
for (const auto [Idx, FixedEncoding, Int] : enumerate(FixedEncodings, Ints)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why leaving const here. I had a quick search. const auto [ is much smaller used in LLVM code base.

$ grep -r 'const auto \[' llvm/| wc
     37     275    3760
$ grep -r 'auto \[' llvm/| wc
    817    5871   82133

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. It seems that we wont need to change anything in this PR. Closing this.

if ((Idx & 7) == 7)
OS << "\n ";

Expand Down
Loading