Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libunwind] Fix libunwind library path for runtime test #110777

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

zeroomega
Copy link
Contributor

This patch fixes an issue when test runner cannot find libwind library when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used.

@zeroomega zeroomega requested a review from ldionne October 2, 2024 01:17
@zeroomega zeroomega requested a review from a team as a code owner October 2, 2024 01:17
@zeroomega
Copy link
Contributor Author

Test run on our downstream bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/clang-linux-x64/b8735236964550803665/overview

This patch should address the build failure introduced in PR #110171

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 2, 2024

@llvm/pr-subscribers-libunwind

Author: Haowei (zeroomega)

Changes

This patch fixes an issue when test runner cannot find libwind library when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used.


Full diff: https://github.com/llvm/llvm-project/pull/110777.diff

1 Files Affected:

  • (modified) libunwind/test/configs/cmake-bridge.cfg.in (+1-1)
diff --git a/libunwind/test/configs/cmake-bridge.cfg.in b/libunwind/test/configs/cmake-bridge.cfg.in
index bd7122bbea32c4..f627f401f9f7b5 100644
--- a/libunwind/test/configs/cmake-bridge.cfg.in
+++ b/libunwind/test/configs/cmake-bridge.cfg.in
@@ -31,4 +31,4 @@ if not @LIBUNWIND_ENABLE_THREADS@:
 # Add substitutions for bootstrapping the test suite configuration
 config.substitutions.append(('%{install-prefix}', '@LIBUNWIND_TESTING_INSTALL_PREFIX@'))
 config.substitutions.append(('%{include}', '@LIBUNWIND_TESTING_INSTALL_PREFIX@/include'))
-config.substitutions.append(('%{lib}', '@LIBUNWIND_TESTING_INSTALL_PREFIX@/lib'))
+config.substitutions.append(('%{lib}', '@LIBUNWIND_TESTING_INSTALL_PREFIX@/@LIBUNWIND_INSTALL_LIBRARY_DIR@'))

@zeroomega
Copy link
Contributor Author

Looks like #108999 broke the check bots.

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the CI is green.

This patch fixes an issue when test runner cannot find libwind library
when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used.
@ldionne
Copy link
Member

ldionne commented Oct 2, 2024

I rebased onto main to trigger the CI again.

@ldionne
Copy link
Member

ldionne commented Oct 2, 2024

This can be merged by whoever sees the CI green first.

@zeroomega
Copy link
Contributor Author

This can be merged by whoever sees the CI green first.

There are 6 failing build so far but all due to the "runner received a shutdown signal", not actually a build/test failure? Should I do another rebase to trigger a rerun? Or we can just land it now?

@ldionne ldionne merged commit 3a6b895 into llvm:main Oct 2, 2024
62 of 63 checks passed
@ldionne
Copy link
Member

ldionne commented Oct 2, 2024

This can be merged by whoever sees the CI green first.

There are 6 failing build so far but all due to the "runner received a shutdown signal", not actually a build/test failure? Should I do another rebase to trigger a rerun? Or we can just land it now?

Merged since we have basically all green now. FYI, the "shutdown signal" thing is that our CI workers are running on preemptable VMs. So they sometimes get killed (shutdown signal) and we have another GH Action that restarts them. It's a bit funky but it saves a lot of cost for the fleet.

Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Oct 3, 2024
This patch fixes an issue when test runner cannot find libwind library
when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used.
xgupta pushed a commit to xgupta/llvm-project that referenced this pull request Oct 4, 2024
This patch fixes an issue when test runner cannot find libwind library
when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants