[MLIR][BUILD] Fix Unicode build issue on Windows. #112300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir Author: Harrison Hao (harrisonGPU) ChangesThis issue is from #77668. I encountered a build issue because it used Unicode. When I built MLIR on Windows with Visual Studio 2022, I faced a build failure. Full diff: https://github.com/llvm/llvm-project/pull/112300.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-rewrite/mlir-rewrite.cpp b/mlir/tools/mlir-rewrite/mlir-rewrite.cpp
index 308e6490726c86..5e3044aa40569b 100644
--- a/mlir/tools/mlir-rewrite/mlir-rewrite.cpp
+++ b/mlir/tools/mlir-rewrite/mlir-rewrite.cpp
@@ -320,25 +320,25 @@ LogicalResult markRanges(RewritePad &rewriteState, raw_ostream &os) {
for (auto it : rewriteState.getOpDefs()) {
auto [startOp, endOp] = getOpRange(it);
- rewriteState.insertText(startOp, "《");
- rewriteState.insertText(endOp, "》");
+ rewriteState.insertText(startOp, " <");
+ rewriteState.insertText(endOp, "> ");
auto nameRange = getOpNameRange(it);
if (isGeneric(it)) {
- rewriteState.insertText(nameRange.Start, "〖");
- rewriteState.insertText(nameRange.End, "〗");
+ rewriteState.insertText(nameRange.Start, " [");
+ rewriteState.insertText(nameRange.End, "] ");
} else {
- rewriteState.insertText(nameRange.Start, "〔");
- rewriteState.insertText(nameRange.End, "〕");
+ rewriteState.insertText(nameRange.Start, " [");
+ rewriteState.insertText(nameRange.End, "] ");
}
}
// Highlight all comment lines.
// TODO: Could be replaced if this is kept in memory.
for (auto commentLine : rewriteState.getSingleLineComments()) {
- rewriteState.insertText(commentLine.Start, "❰");
- rewriteState.insertText(commentLine.End, "❱");
+ rewriteState.insertText(commentLine.Start, "{");
+ rewriteState.insertText(commentLine.End, "}");
}
return success();
|
jpienaar
approved these changes
Oct 15, 2024
| } else { | ||
| rewriteState.insertText(nameRange.Start, "〔"); | ||
| rewriteState.insertText(nameRange.End, "〕"); | ||
| rewriteState.insertText(nameRange.Start, " ["); |
There was a problem hiding this comment.
Lets perhaps make this something like " ![" and "]! " - previously one could differentiate between generic or not form.
There was a problem hiding this comment.
Okay, I have already updated it.
harrisonGPU
force-pushed
the
harrison/dix
branch
from
b0daa74
to
cde0eba
Compare
|
Hi @jpienaar , I have updated this PR, please take a look again. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is from #77668. I encountered a build issue because it used Unicode. When I built MLIR on Windows with Visual Studio 2022, I faced a build failure.