Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb] Added Debuginfod tests and fixed a couple issues #92572

Merged
merged 12 commits into from
May 22, 2024

Conversation

kevinfrei
Copy link
Contributor

@kevinfrei kevinfrei commented May 17, 2024

Here we go with attempt number five. Again, no changes to the LLDB code diff, which has been reviewed several times.

For the tests, I added a @skipIfCurlSupportMissing annotation so that the Debuginfod mocked server stuff won't run, and I also disabled non-Linux/FreeBSD hosts altogether, as they fail for platform reasons on macOS and Windows. In addition, I updated the process for extracting the GNU BuildID to no create a target, per some feedback on the previous diff.

For reference, previous PR's (landed, backed out after the fact for various reasons) #90622, #87676, #86812, #85693

@kevinfrei kevinfrei marked this pull request as ready for review May 17, 2024 16:31
@kevinfrei
Copy link
Contributor Author

kevinfrei commented May 17, 2024

FYI: The previous diff exposed a bug in some ARM code that @DavidSpicket fixed in #91585, but (for understandable reasons) he didn't want to be left holding the bag on restoring this diff, so I integrated some post-land feedback from @labath and put the diff back up for review.

@clayborg clayborg merged commit e558d21 into llvm:main May 22, 2024
7 checks passed
@mysterymath
Copy link
Contributor

mysterymath commented May 22, 2024

This broke the Fuchsia CI builders' LLDB test suite:

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8747217173107569041/overview

FAIL: LLDB (/b/s/w/ir/x/w/llvm_build/bin/clang-x86_64) :: test_normal_stripped_split_with_dwp (TestDebuginfodDWP.DebugInfodDWPTests.test_normal_stripped_split_with_dwp)
======================================================================
ERROR: test_debuginfod_both_okd_symfiles_from_service (TestDebuginfodDWP.DebugInfodDWPTests.test_debuginfod_both_okd_symfiles_from_service)
   Test behavior with both the only-keep-debug symbols and the dwp symbols
----------------------------------------------------------------------
Error when building test subject.

"/b/s/w/ir/x/w/llvm_build/bin/dwp" -o "a.out.dwp" main.dwo
/bin/sh: 1: /b/s/w/ir/x/w/llvm_build/bin/dwp: not found
make: *** [Makefile.rules:584: a.out.debug] Error 127
make: Leaving directory '/b/s/w/ir/x/w/llvm_build/lldb-test-build.noindex/debuginfod/SplitDWARF/TestDebuginfodDWP.test_debuginfod_both_okd_symfiles_from_service'

Test Directory:
/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/debuginfod/SplitDWARF
======================================================================
ERROR: test_expr_dwarf (TestSharedLibStrippedSymbols.SharedLibStrippedTestCase.test_expr_dwarf)
   Test that types work when defined in a shared library and forwa/d-declared in the main executable
----------------------------------------------------------------------
Error when building test subject.


...

ifeq "" "YES"
/bin/sh: 1: ifeq: not found
make: *** [Makefile.rules:631: libfoo.so] Error 127
make: Leaving directory '/b/s/w/ir/x/w/llvm_build/lldb-test-build.noindex/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.test_expr_dwarf'

mysterymath added a commit that referenced this pull request May 22, 2024
mysterymath added a commit that referenced this pull request May 22, 2024
)

Reverts #92572 due to Fuchsia CI breakages (using CLI
tools in tests that weren't necessarily built).
@kevinfrei kevinfrei deleted the debuginfod-tests-curl-dependent branch July 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants