Adding reshape fall back case for unimplemented cases in aten view for time being #2515
Conversation
| op, "unimplemented: input rank 0 is not supported"); | ||
| // return rewriter.notifyMatchFailure( | ||
| // op, "unimplemented: input rank 0 is not supported"); | ||
| rewriter.replaceOpWithNewOp<tensor::ReshapeOp>(op, resultType, input, sizeTensor); |
There was a problem hiding this comment.
tensor::ReshapeOp is not a good op to lower to. See discussion here: #1168
Do you have examples of the cases you need to handle that currently fail? I can help brainstorm approaches
There was a problem hiding this comment.
Others (Gaurav, Mahesh) are working on another approach with collapsing and expanding. This is just a short term fix until we get that patch landed. Specifically, we are trying to lower llama and currently blocked. I'll add the specific issue to this thread once I get it.
There was a problem hiding this comment.
Llama_2_7b_chat_hf_torch.mlir:958:10: error: failed to legalize operation 'torch.aten.view' that was explicitly marked illegal
%5 = torch.aten.view %3, %4 : !torch.vtensor<[1,?],si64>, !torch.list<int> -> !torch.vtensor<[1,?],si64>
^
Llama_2_7b_chat_hf_torch.mlir:958:10: note: see current operation: %55 = "torch.aten.view"(%53, %54) : (!torch.vtensor<[1,?],si64>, !torch.list<int>) -> !torch.vtensor<[1,?],si64>
Llama_2_7b_chat_hf_torch.mlir:12546:10: error: failed to legalize operation 'torch.aten.view' that was explicitly marked illegal
%6 = torch.aten.view %4, %5 : !torch.vtensor<[1,?],si64>, !torch.list<int> -> !torch.vtensor<[1,?],si64>
^
Llama_2_7b_chat_hf_torch.mlir:12546:10: note: see current operation: %69 = "torch.aten.view"(%67, %68) : (!torch.vtensor<[1,?],si64>, !torch.list<int>) -> !torch.vtensor<[1,?],si64>
I think this is the same issue that I solved locally by adding that logic that you were asking about in #2485
There was a problem hiding this comment.
its still weird to me that this fails. Let me double check I'm on main too
There was a problem hiding this comment.
yeah does still happen ToM,
https://storage.googleapis.com/shark_tank/dan/repro.mlir
https://storage.googleapis.com/shark_tank/dan/repro_readable.mlir
iree-compile --iree-input-type=torch repro.mlir
There was a problem hiding this comment.
It would be good to know what is blocking things downstream. @dan-garvey mentioned above that the issue might be fixed by making a small change to how the output shape is calculated. If so, this would be preferred to adding a new op that downstream projects have to handle. A small reproducer of what needs solving would be very useful here.
If the issue turns out to be very hard to handle given the current setup, then the plan you've outlined makes sense.
There was a problem hiding this comment.
yeah so I have a branch that solves all the issues without resorting to reshape. I'll have to make the small repro for the sake of tests for that patch anyway, so I think we can close this for now.
There was a problem hiding this comment.
I'll aim to have that up for re"view" today
There was a problem hiding this comment.
Perfect! Thanks @dan-garvey
There was a problem hiding this comment.
Closing this PR for now then.
No description provided.