Breakup python pytorch deps #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
force-pushed
the
breakup_python_pytorch_deps
branch
from
b6e7e13
to
1fcaf74
Compare
stellaraccident
force-pushed
the
breakup_python_pytorch_deps
branch
from
1fcaf74
to
e9a9b62
Compare
powderluv
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lifts the core of the jit_ir_importer and ltc out of the pt1 project, making them peers to it. As a side-effect of this layering, now the "MLIR bits" (dialects, etc) are not commingled with the various parts of the pt1 project, allowing pt1 and ltc to overlay cleanly onto a more fundamental "just MLIR" Python core. Prior to this, the Python namespace was polluted to the point that this could not happen.
That "just MLIR" Python core will be introduced in a followup, which will create the space to upstream the FX and ONNX pure Python importers.
This primary non-NFC change to the API is:
torch_mlir.dialects.torch.importer.jit_ir->torch_mlir.jit_ir_importer.The rest is source code layering so that we can make the pt1 project optional without losing the other features.
Progress on #2546.