Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lowering of torch.aten.lgamma #2741

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement lowering of torch.aten.lgamma #2741

wants to merge 2 commits into from

Conversation

mmakevic
Copy link
Contributor

Description

Implemented lowering of the lgamma function using Lanczos approximation.

Closing nod-ai/SHARK-ModelDev#317

@mmakevic mmakevic marked this pull request as draft January 12, 2024 09:08
@mmakevic mmakevic marked this pull request as ready for review January 12, 2024 09:08
@mmakevic
Copy link
Contributor Author

@vivekkhandelwal1 not sure if you're the right person to ping, but could you review the PR? The last check is timing out, don't know why..

vivekkhandelwal1
vivekkhandelwal1 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address small nits. Rest LGTM

lib/Conversion/TorchToLinalg/Uncategorized.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchToLinalg/Uncategorized.cpp Outdated Show resolved Hide resolved
@mmakevic
Copy link
Contributor Author

Hi @vivekkhandelwal1, I think the issue with CI was resolved so could you rerun checks please? Thanks!

@vivekkhandelwal1
Copy link
Collaborator

Hi @vivekkhandelwal1, I think the issue with CI was resolved so could you rerun checks please? Thanks!

Done

@mmakevic mmakevic marked this pull request as draft February 22, 2024 11:27
@mmakevic mmakevic marked this pull request as ready for review February 22, 2024 11:28
@mmakevic
Copy link
Contributor Author

@vivekkhandelwal1 any idea why the regression tests are failing? I can't reproduce it locally

@vivekkhandelwal1
Copy link
Collaborator

@vivekkhandelwal1 any idea why the regression tests are failing? I can't reproduce it locally

The issue should be fixed if you rebase your branch over TOM and push it.

@mmakevic
Implement lowering of torch.aten.lgamma
18991ae 
Fix precision issues around zero and inf

Add type check

Move test, add tests for edge cases
@mmakevic
Removed unused imports
737e51c
@mmakevic
Copy link
Contributor Author

mmakevic commented Mar 1, 2024

@vivekkhandelwal1 Thanks for the tip, that fixed the regression test issue. However, the e2e tests are timing out now (again - can't reproduce the issue locally). Any ideas?

@vivekkhandelwal1
Copy link
Collaborator

@vivekkhandelwal1 Thanks for the tip, that fixed the regression test issue. However, the e2e tests are timing out now (again - can't reproduce the issue locally). Any ideas?

When you run these tests locally, do they pass?

@mmakevic
Copy link
Contributor Author

mmakevic commented Mar 6, 2024

@vivekkhandelwal1 Thanks for the tip, that fixed the regression test issue. However, the e2e tests are timing out now (again - can't reproduce the issue locally). Any ideas?

When you run these tests locally, do they pass?

@vivekkhandelwal1 Yes, they do

@mmakevic mmakevic mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekkhandelwal1 vivekkhandelwal1 Awaiting requested review from vivekkhandelwal1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmakevic @vivekkhandelwal1