Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lowering of torch.aten.linalg_cross #2986

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Implement lowering of torch.aten.linalg_cross #2986

merged 2 commits into from
Mar 13, 2024

Conversation

ptrifunovic98
Copy link
Contributor

@ramiro050 ramiro050 self-requested a review March 8, 2024 21:02
ramiro050
ramiro050 requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some minor requests. Thanks!

lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
projects/pt1/python/torch_mlir_e2e_test/test_suite/matmul.py Show resolved Hide resolved
lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
@ptrifunovic98
Copy link
Contributor Author

@ramiro050, thanks for the review! I have updated everything you mentioned. The CI tests passed, so if everything looks good now, I think it is ready for merging.

ramiro050
ramiro050 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramiro050 ramiro050 merged commit 524ff99 into llvm:main Mar 13, 2024
3 checks passed
@renxida renxida mentioned this pull request Apr 3, 2024
Open
79 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiro050 ramiro050 ramiro050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torch.aten.linalg_cross
2 participants
@ptrifunovic98 @ramiro050