Support select_last_index attribute of onnx argmax op #3192
+59
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchen62
force-pushed
the
fix_onnx_argmax
branch
2 times, most recently
from
ebadf26
to
93c8fc6
Compare
jinchen62
force-pushed
the
fix_onnx_argmax
branch
2 times, most recently
from
126db5d
to
c6c1a15
Compare
jinchen62
force-pushed
the
fix_onnx_argmax
branch
from
c6c1a15
to
9a25d64
Compare
rsuderman
approved these changes
Apr 23, 2024
|
Is there a way we can verify via an end-to-end test |
|
@rsuderman There were these tests failing because of this issue. Now they all compile and match the values of result, but have the dtype mismatch issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests listed in nod-ai/SHARK-ModelDev#635 all compiled, but having run issue of dtype mismatch of i/si.