Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support select_last_index attribute of onnx argmin op #3212

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jinchen62
Copy link
Collaborator

The tests listed in nod-ai/SHARK-Turbine#648 all compiled, and the values of results match, but having runtime issue of dtype mismatch of i/si.

Copy link
Contributor

@rsuderman rsuderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto comment about end-to-end test

@jinchen62 jinchen62 merged commit 09d4204 into llvm:main Apr 23, 2024
3 checks passed
@jinchen62 jinchen62 deleted the fix_onnx_argmin branch April 23, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants