[Torch] Implements TorchToLinalg lowering of torch.ops.aten._weight_norm_interface #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
requested changes
Jul 12, 2024
projects/pt1/python/torch_mlir/jit_ir_importer/build_tools/abstract_interp_lib_gen.py
Outdated
Show resolved
Hide resolved
added 3 commits
July 12, 2024 17:03
|
Since the ONNX test on _weight_norm_interface has been failing due to it not being a ONNX supported TorchScript operator, I've put the WeightNormInterfaceModule test under ONNX_XFAIL_SET. I've also opened pytorch/pytorch#130644 to see if it can be implemented, removing the need for an XFAIL. |
rsuderman
approved these changes
Jul 12, 2024
vivekkhandelwal1
requested changes
Jul 16, 2024
vivekkhandelwal1
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves nod-ai/SHARK-Turbine#757.
Adds TorchToLinalg lowering for
Aten_WeightNormInterfaceOp.