-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations to estonian #94
Conversation
In regards to this, I think the confusion come from the fact that air quality scales try to answer one of two questions...
It is not always clear what question an AQI scale is trying to answer unless you refer to the governing documents. Here is another issue on this project where a similar question is asked, #31. I have quoted part of my reply here for reference.
|
Hi Luke. Thank you for the clarification. Yes, I found the same answers with my research because I also thought that it might be a bug, then I realized that it essentially represents the pollution level (why did they not name it like that? :D ) from low to high. |
You're right, this is definitely confusing as is. Maybe the label "Air Quality" needs to change depending on the scale selected. For EU CAQI the label should be "Pollution" or "Pollution Level". I'm going to add some code so the label used will depend on what AQI is selected. Then you can correct the translation. |
Based on your suggestion, I have reworked the code so that depending on the AQI scale being used, it will either say "Air Quality" or "Air Pollution.". I updated your pull request with the new fields so that it is compatible with the new changes to upstream. c7f01f5 You should be good to update the translations back to the true meanings and it should be more clear now. |
It was a good workaround 👍 |
Looks great! Give yourself a pat on the back for navigating it all like a pro, pretty impressive for a non-developer I would never have known :) Thank you for your contribution. |
The git part I was navigating with ChatGPT, which is impressive :D |
Hi Luke, great project! Good instructions and easy to set up.
I added the estonian translations.
I found the AQI (EUROPE_CAQI) part confusing as "very low" is supposed to mean the quality is good :D. So I translated the "Air Quality Index" as just "Air Quality" in the oppopsite way from "very bad" to "very good" in estonian.