Break formatting code into formatting.py #198
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the code for formatting
ufloat
into its own module:formatting.py
.I made two tiny moves beyond what I would call pure copy and paste:
isinfinite
method and never try to import it frommath
.deprecation
function fromcore.py
intoformatting.py
to avoid dealing with a circular import. The proper way to do this would be to placedeprecation()
into a commonutilities.py
or similar that bothcore.py
andformatting.py
could import from. But I didn't want to wade into that move in this PR.