Change example JSON responses to use Typescript types #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to clear out inconsistencies with the JSON examples in the LUDs.
Types such as
MilliSatoshihas been changed tonumberto clear up any confusions regarding what a value is supposed to be. Context-important information has been moved to a comment on the same line instead.The rationale behind Typescript types being used is because it's the closest to Javascript, which in turn is the closest to JSON.
The keys in the examples has been changed to be an actual string, as is required to be valid JSON.
Not sure if this is a worthwhile improvement or an actual improvement at all, but it at least brings some consistency.