[FOPS-5403] Create new Attachment.content_disposition #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doughss
requested review from
a team,
fsjunior,
wmarquardt,
Yanhenning,
sorattomanuela and
lucastonelli
|
Try to fix the check-all as I did here https://github.com/loadsmart/gmail-wrapper/pull/29/files, we were facing some problems with tox in the circleci config file |
Yanhenning
approved these changes
Jan 3, 2024
doughss
force-pushed
the
FOPS-5403
branch
4 times, most recently
from
a2d8f93
to
7632f3f
Compare
raelmax
approved these changes
Jan 3, 2024
lucastonelli
approved these changes
Jan 4, 2024
Yanhenning
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context for the change
We adding a new field
content_dispositionto Attachment. So we can get it easily by accessingAttachment.content_dispositionA clear description of the change
Create new Attachment.content_disposition #30
Testing
Testing instructions
Unit test
Rollback
Rollback instructions
Revert PR
JIRA issue
https://loadsmart.atlassian.net/browse/FOPS-5403