Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATL-3241: add geo_ip_sort to intl_autocomplete #337

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

amaan-lob
Copy link
Contributor

@amaan-lob amaan-lob commented Jun 7, 2022

Fixes AV-3241

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Adding geo_ip_sort field to intl_autocompletions request body.

Areas of Concern (optional)

@amaan-lob amaan-lob requested a review from vmangwani June 7, 2022 00:38
Copy link
Contributor

@vmangwani vmangwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sudoku-lord sudoku-lord self-requested a review June 8, 2022 00:10
@sudoku-lord
Copy link
Contributor

I will take a look tomorrow morning. @amaan-lob do you mind fixing the merge conflict?

@amaan-lob
Copy link
Contributor Author

I will take a look tomorrow morning. @amaan-lob do you mind fixing the merge conflict?

Sorry, it took me a while to get back to this but the merge conflict should now be resolved.

@amaan-lob amaan-lob requested a review from a team as a code owner August 1, 2022 22:41
@jho44 jho44 merged commit 54c0ac0 into main Aug 1, 2022
@jho44 jho44 deleted the atl_3241_add_ip_sort branch August 1, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants