Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only test what's needed in pre-commit #370

Merged
merged 1 commit into from
Aug 1, 2022
Merged

only test what's needed in pre-commit #370

merged 1 commit into from
Aug 1, 2022

Conversation

jho44
Copy link
Contributor

@jho44 jho44 commented Jul 29, 2022

Fixes ticket

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Changed husky pre-commit hook.
Should I implement this for the GHA too?

@jho44 jho44 requested review from a team and sudoku-lord as code owners July 29, 2022 22:54
@sudoku-lord sudoku-lord merged commit 95d46fa into main Aug 1, 2022
@sudoku-lord sudoku-lord deleted the only_test_whats_needed branch August 1, 2022 19:26
@jho44 jho44 mentioned this pull request Aug 1, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudoku-lord sudoku-lord sudoku-lord approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jho44 @sudoku-lord