Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added separate campaign model to avoid recursion and clean up creative #377

Merged
merged 5 commits into from
Aug 9, 2022
Merged

added separate campaign model to avoid recursion and clean up creative #377

merged 5 commits into from
Aug 9, 2022

Conversation

sudoku-lord
Copy link
Contributor

@sudoku-lord sudoku-lord commented Aug 8, 2022 •
edited
Loading

@sudoku-lord sudoku-lord requested a review from a team as a code owner August 8, 2022 18:14
jho44
jho44 suggested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@jho44 jho44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the changes I mentioned before. Looks good otherwise~ Thanks for quenching the drought.

@sudoku-lord sudoku-lord requested a review from jho44 August 9, 2022 18:38
@jho44 jho44 merged commit 04a2a86 into main Aug 9, 2022
@jho44 jho44 deleted the campaigns_recursion branch August 9, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jho44 jho44 jho44 approved these changes

@BennyKitchell BennyKitchell Awaiting requested review from BennyKitchell BennyKitchell was automatically assigned from lob/developer-experience

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudoku-lord @jho44