Pmapi 1708 add uploads to campaigns #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julielinter Sorry about the postman script not working. That will be resolved in this PR but it has yet to be approved. So I think you can ignore that breaking :) |
| description: A single-element array containing the upload object that is assocated with this campaign. | ||
| type: array | ||
| minItems: 0 | ||
| maxItems: 1 |
There was a problem hiding this comment.
Just want to make sure to call this out, I assume this will be bumped in the future. So we are using an array of one to keep this flexible?
There was a problem hiding this comment.
@BennyKitchell That's correct!
BennyKitchell
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PMAPI-1708
Checklist
mainnpm run bundleoutputs nothing suspectnpm run postmanoutputs nothing suspectChanges
Adds
uploadsproperty to Campaigns responseuploadsis an array of a single Upload object that is associated with the Campaign (similar tocreativesof a Campaign with only a single Upload object)Areas of Concern (optional)