Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMAPI-1875: add campaign send endpoint #396

Merged
merged 4 commits into from
Sep 28, 2022
Merged

PMAPI-1875: add campaign send endpoint #396

merged 4 commits into from
Sep 28, 2022

Conversation

jlincodes
Copy link
Contributor

@jlincodes jlincodes commented Sep 27, 2022 •
edited
Loading

Fixes PMAPI-1875

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

  • Updates documentation with new Campaigns Send endpoint: POST /v1/campaigns/:id/send
    • This endpoint replaces the old method of "sending" or trigger a campaign for processing, which consisted of two PATCH requests - one to /v1/campaigns/:id and the other to /v1/uploads/:id. However neither of these updates endpoints are deprecated. I did remove state from the Upload PATCH however since that's no longer relevant for this endpoint.

Areas of Concern (optional)

@jlincodes jlincodes self-assigned this Sep 27, 2022
@jlincodes jlincodes marked this pull request as ready for review September 27, 2022 21:47
BennyKitchell
BennyKitchell approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@BennyKitchell BennyKitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jlincodes jlincodes merged commit 0a26c01 into main Sep 28, 2022
@jlincodes jlincodes deleted the PMAPI-1875-add-campaign-send-endpoint branch September 28, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BennyKitchell BennyKitchell BennyKitchell approved these changes

Assignees

@jlincodes jlincodes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlincodes @BennyKitchell