Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE-419 update check 'to' address info #456

Merged
merged 9 commits into from
Aug 22, 2023
Merged

SE-419 update check 'to' address info #456

merged 9 commits into from
Aug 22, 2023

Conversation

mike-r-morgan
Copy link
Contributor

@mike-r-morgan mike-r-morgan commented Aug 16, 2023 •
edited
Loading

Fixes # SE-419

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Check to.address_line1|address_line2 maximum character count corrected to 50

Areas of Concern (optional)

need to confirm tests pass

@bamohan
Copy link

bamohan commented Aug 21, 2023

@mmorgan-lob => Can you add Walker to the issue as a follower (More details here) cc @lobwalkerp . Ty so much!

@mike-r-morgan
Copy link
Contributor Author

@mmorgan-lob => Can you add Walker to the issue as a follower (More details here) cc @lobwalkerp . Ty so much!

Walker is already a watcher on the JIRA ticket

BennyKitchell
BennyKitchell approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@BennyKitchell BennyKitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will probably need to bump the version one more time. But 👍

@mike-r-morgan mike-r-morgan merged commit fa0b2b5 into main Aug 22, 2023
2 checks passed
@mike-r-morgan mike-r-morgan deleted the SE-419 branch August 22, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BennyKitchell BennyKitchell BennyKitchell approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-r-morgan @bamohan @BennyKitchell