Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add campaigns #237

Merged
merged 7 commits into from
Oct 7, 2022
Merged

add campaigns #237

merged 7 commits into from
Oct 7, 2022

Conversation

jho44
Copy link
Contributor

@jho44 jho44 commented Sep 16, 2022

Description

Regenerated SDK, but took out stuff like Creatives API, Uploads API, Default API, related models, etc.
Added Campaigns API, related models, and unit/integration tests.

Story

JIRA-1266

Related PR's

Generator PR 1
Generator PR 2

Verify

  • Code runs without errors
  • Tests pass with >=85% coverage

@BennyKitchell
Copy link
Contributor

@jho44 This doesn't look correct, I see in the tests we are making calls using Inline 200. This is a generic response type that basically means we have a problem in our generation. Were you able to successfully do everything in Campaigns with this?

@jho44
Copy link
Contributor Author

jho44 commented Sep 28, 2022

@jho44 This doesn't look correct, I see in the tests we are making calls using Inline 200. This is a generic response type that basically means we have a problem in our generation. Were you able to successfully do everything in Campaigns with this?

I was able to successfully do everything in Campaigns with this, but I've since fixed it with this Generator PR.

@coveralls
Copy link

coveralls commented Sep 28, 2022

Pull Request Test Coverage Report for Build 3141362779

  • 146 of 147 (99.32%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 99.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/campaigns-api.ts 142 143 99.3%
Totals Coverage Status
Change from base Build 3137516625: 1.6%
Covered Lines: 1984
Relevant Lines: 1987

💛 - Coveralls

@BennyKitchell BennyKitchell merged commit 2a15a07 into main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants