Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC-1373 Change TopNavDropdown to not require title prop #416

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

kencrim
Copy link
Contributor

@kencrim kencrim commented Aug 17, 2023

GC-1373

Description

  • Previous PR was causing console warnings because the new icon variants didn't have titles.

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

@kencrim kencrim requested a review from a team as a code owner August 17, 2023 15:54
@guardrails
Copy link

guardrails bot commented Aug 17, 2023

⚠️ We detected 11 security issues in this pull request:

Vulnerable Libraries (11)
Severity Details
High pkg:npm/@babel/[email protected] (t) upgrade to: > 7.18.6
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Medium pkg:npm/[email protected] (t) upgrade to: > 8.7.1
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
Medium pkg:npm/[email protected] (t) upgrade to: > 7.11.0
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Informational pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-416.d11k469e311m4w.amplifyapp.com

@@ -70,8 +70,7 @@ export default {
components: { ChevronDown },
props: {
title: {
type: String,
required: true
type: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should set a default of '' here

@kencrim kencrim merged commit a60418f into main Aug 17, 2023
4 checks passed
@kencrim kencrim deleted the GC-1373/title-not-required branch August 17, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants