Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BILL-3514/subnav update #417

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

shannamurry
Copy link
Contributor

@shannamurry shannamurry commented Sep 13, 2023

JIRA

  • A link to the JIRA ticket

Description

  • There is an issue on the Billing overview page in Dashboard, transaction tab - since the results are paginated, if you flip through them the query string gets pushed onto the url - which then causes the active tab to not think it's active. By adding this optional stringToMatch prop we can turn it into a regex match so that the pagination query params do not cause the tab to think it's inactive

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

@shannamurry shannamurry requested a review from a team as a code owner September 13, 2023 20:51
@guardrails
Copy link

guardrails bot commented Sep 13, 2023

⚠️ We detected 11 security issues in this pull request:

Vulnerable Libraries (11)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Medium pkg:npm/[email protected] (t) upgrade to: > 8.7.1
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
High pkg:npm/@babel/[email protected] (t) upgrade to: > 7.18.6
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
Critical pkg:npm/@storybook/[email protected] (t) upgrade to: > 6.5.9
Medium pkg:npm/[email protected] (t) upgrade to: > 7.11.0

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-417.d11k469e311m4w.amplifyapp.com

@shannamurry shannamurry merged commit 48865ef into main Sep 13, 2023
4 checks passed
@shannamurry shannamurry deleted the BILL-3514/update_subnavigation_component branch September 13, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants