Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add Ai21Labs model support in Bedrock #3808

Closed
wants to merge 4 commits into from

Conversation

hezhijie0327
Copy link
Contributor

@hezhijie0327 hezhijie0327 commented Sep 7, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

增加对 Bedrock 中 ai21.jamba-instruct-v1:0 模型的对话支持

Note: 仅在 us-east-1 区域可用

📝 补充信息 | Additional Information

image

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 7, 2024
Copy link

vercel bot commented Sep 7, 2024

@hezhijie0327 is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @hezhijie0327

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 🌠 Feature Request New feature or request | 特性与建议 label Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 55.39568% with 62 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (18a240c) to head (4a59615).
Report is 218 commits behind head on main.

Files with missing lines Patch % Lines
src/libs/agent-runtime/bedrock/index.ts 9.25% 49 Missing ⚠️
...c/libs/agent-runtime/utils/streams/bedrock/ai21.ts 84.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3808      +/-   ##
==========================================
- Coverage   92.45%   92.30%   -0.15%     
==========================================
  Files         482      483       +1     
  Lines       34363    34499     +136     
  Branches     2125     2130       +5     
==========================================
+ Hits        31772    31846      +74     
- Misses       2591     2653      +62     
Flag Coverage Δ
app 92.30% <55.39%> (-0.15%) ⬇️
server 97.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Oct 28, 2024

我倾向考虑直接集成 AWS Bedrock 的统一接口方案( Converse API )。 https://docs.aws.amazon.com/bedrock/latest/userguide/conversation-inference.html

不然感觉一个一个 model 接入成本太高了,也不好维护,#3810#4216 也同理

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


I tend to consider directly integrating AWS Bedrock's unified interface solution (Converse API). https://docs.aws.amazon.com/bedrock/latest/userguide/conversation-inference.html

Otherwise, it feels like the cost of accessing each model is too high and difficult to maintain. The same applies to #3810 and #4216.

@hezhijie0327 hezhijie0327 deleted the bedrock_ai21 branch October 28, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌠 Feature Request New feature or request | 特性与建议 size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants