-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
โจ feat: allow commercial license to customize inbox assistant #4148
base: main
Are you sure you want to change the base?
Conversation
Use config env for default assistance
@khanhduyvt0101 is attempting to deploy a commit to the LobeHub Pro Team on Vercel. A member of the Team first needs to authorize it. |
๐ @khanhduyvt0101 Thank you for raising your pull request and contributing to our Community |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4148 +/- ##
========================================
Coverage 92.30% 92.30%
========================================
Files 498 499 +1
Lines 36243 36310 +67
Branches 2182 2341 +159
========================================
+ Hits 33454 33517 +63
- Misses 2789 2793 +4
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
@khanhduyvt0101 hi, could you please seperate a PR just for the code format & lint fix? I think this PR should focus on the customize~ |
Here you go, please merge this PR first: #4161, then I'll update this one. @arvinxx |
@arvinxx , Please consider and merge this PR man |
@khanhduyvt0101 yeah, I think this idea is great. I'm reviewing the code now |
src/app/(main)/chat/@session/features/SessionListContent/Inbox/index.tsx
Outdated
Show resolved
Hide resolved
Just updated based on your review @arvinxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the custom
locale may not be a good pattern. Because most users don't need this file but it will be bundled to all users. Need to discuss a better way to handle it
Hi @arvinxx, I updated the code base based on your feedback. The custom locales only generate when |
Hi @arvinxx , Could you please help me re-consider this PR? |
๐ป ๅๆด็ฑปๅ | Change Type
๐ ๅๆด่ฏดๆ | Description of Change
Commercial license dev can set feature flag
commercial_inbox = true
to enable customizing the default inbox assistant. The customization is done through a dedicated locale filecustom.ts
to avoid conflict from other updates.