Auth scram sha 256 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support more future proof hashing algorithm for SCRAM authentication. Compatible with mongoDB 4.0 and higher.
Removes custom SCRAM implementation replacing it with a wrapper for the existing xdg-go/scram library. Changes the saslNewScram interface to take a new type *scram.Method argument replacing the func () hash.Hash type. Adds a scram.NewMethod function that validates and returns a supported method.
Responsibility for checking if the authentication process is completed it placed in the Step function, hence there should be no need to check the response object done field independently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: globalsign#282