Improvements related to bulk feature copy or move between layers #218
Conversation
|
Hi @fgdrf , |
|
@nprigour Actually it's still not merged yet because of lack of time to review it. ;) Let's finish #279 first, because we will have some follow-up tasks regarding IP-Review (additional picky back CQ's and for GT itself, I guess 14.1 was approved with some exceptions). Anybody else to review and comment this changeset now? |
plugins/org.locationtech.udig.core/src/org/locationtech/udig/core/internal/FeatureUtils.java
Outdated
Show resolved
Hide resolved
...ationtech.udig.tools.jgrass/src/org/locationtech/udig/tools/jgrass/utils/OperationUtils.java
Show resolved
Hide resolved
.../org.locationtech.udig.core.tests/src/org/locationtech/udig/core/NumberAdaptableFactory.java
Outdated
Show resolved
Hide resolved
exist. Consider existence of adapters during feature copy between layers Signed-off-by: Nikolaos Pringouris <[email protected]>
|
@nprigour Can we go through the comments to get it onto master? |
NumberAdaptableFactory Signed-off-by: Nikolaos Pringouris <[email protected]>
nprigour
force-pushed
the
CopyMoveFeaturesImprovements
branch
from
564dacd
to
a8ba878
Compare
|
Ok @fgdrf I addressed all of your comments providing some basic unit testing related to the examplary AdaptableFactory that transforms between various types of numbers. IMHO the feature provided by this PR is one of the most powerful enhancement in udig SDK since it enables a potential developer to copy and move feature between layers even with completely different types providing their names are the same and that it has defined an appropriate implementation of IAdapterFactory. |
|
Just as a reminder that upgrading to geotools 22.x will affect this enhancement due to geotools/geotools#2525. Probably this differentiation of behavior will be detected by the added DataUtilities#compare unit test so we will go through it then. |
…ationtech#218) * Enables to copy of features between layers with reordered attribute fields Considers existence of adapters during feature copy between layers Signed-off-by: Nikolaos Pringouris <[email protected]>
Enhancements include:
Included example shp files to test the behavior via the UI.
test_shp_files.zip
Signed-off-by: Nikolaos Pringouris [email protected]