Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes enablement of layer move up/down actions #248

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Jul 18, 2017

see issue #247

Now the selection is used to enable/disable Move Up/Down Action.

grafik

grafik

If there are Layers in between, that are not selected, it's possible to move up/down

grafik

As a result of Move Up the selection it would look like this:

grafik

Signed-off-by: Frank Gasdorf [email protected]

@fgdrf
Copy link
Contributor Author

fgdrf commented Jul 18, 2017

@egouge Is this interesting for SMART, isn't it?

@nprigour
Copy link
Contributor

Nice improvement 👍 Why is it not yet integrated in the master branch?

@fgdrf
Copy link
Contributor Author

fgdrf commented Feb 13, 2018

@nprigour, Thanks!

I guess there is a little issue left. Assume the user has three selected layers such as
grafik

and clicks on the move down action. The first move is fine:
grafik

while the second mixes up the two lower once:
grafik

Not sure if it is really a bug but kind of confusing, isn't it?

@nprigour
Copy link
Contributor

added a pull request to your local branch in relation to this. If you agree you can merge it and proceed with integration in master

@fgdrf
Copy link
Contributor Author

fgdrf commented Feb 13, 2018

I'm going to test your contribution. Thanks for collaboration! Appreciate your help here!

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Feb 13, 2018
@fgdrf fgdrf merged commit 467f237 into locationtech:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants