Fix processing of account.application.deauthorized events #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #33 +/- ##
==========================================
+ Coverage 99.05% 99.06% +<.01%
==========================================
Files 34 34
Lines 1799 1814 +15
Branches 159 160 +1
==========================================
+ Hits 1782 1797 +15
Misses 9 9
Partials 8 8
Continue to review full report at Codecov.
|
ticosax
force-pushed
the
signal-account-deauthorize
branch
from
7858405
to
31b4db7
Compare
blueyed
reviewed
Oct 26, 2017
pinax/stripe/webhooks.py
Outdated
| ) | ||
| except stripe.error.PermissionError as exc: | ||
| if stripe_account_id not in str(exc): | ||
| raise exc |
There was a problem hiding this comment.
This should be more specific, and needs to cover the re-raise.
blueyed
reviewed
Oct 26, 2017
pinax/stripe/webhooks.py
Outdated
| """ | ||
| Validate incoming events. | ||
|
|
||
| We don't fetch remote the event as we lost access to the account where the event belongs. |
blueyed
reviewed
Oct 26, 2017
pinax/stripe/webhooks.py
Outdated
| @@ -144,8 +144,30 @@ class AccountApplicationDeauthorizeWebhook(Webhook): | |||
| name = "account.application.deauthorized" | |||
| description = "Occurs whenever a user deauthorizes an application. Sent to the related application only." | |||
|
|
|||
| def validate(self): | |||
| """ | |||
| Validate incoming events. | |||
There was a problem hiding this comment.
*"Specialized validation of incoming events."
ticosax
force-pushed
the
signal-account-deauthorize
branch
from
a067097
to
a951d06
Compare
blueyed
reviewed
Oct 26, 2017
pinax/stripe/webhooks.py
Outdated
| self.event.validated_message = self.event.webhook_message | ||
| self.event.stripe_account = self.stripe_account | ||
| else: | ||
| raise ValueError("The remote account is still valid. This might be a hostile event.") |
ticosax
force-pushed
the
signal-account-deauthorize
branch
2 times, most recently
from
d49106b
to
5ed86af
Compare
don't try to fetch the event as we lost access to remote account
blueyed
reviewed
Oct 26, 2017
| webhook_message=data, | ||
| ) | ||
| RetrieveMock.side_effect = stripe.error.PermissionError( | ||
| "The provided key 'sk_test_********************abcd' does not have access to account 'acc_aa'") |
blueyed
reviewed
Oct 26, 2017
| to make you believe the account has been disabled despite it is still functioning. | ||
| """ | ||
| stripe_account_id = self.event.webhook_message["account"] | ||
| self.stripe_account = models.Account.objects.filter(stripe_id=stripe_account_id).first() |
There was a problem hiding this comment.
Do we want to blow up in case we are not in sync ?
blueyed
reviewed
Oct 26, 2017
| self.event.validated_message = self.event.webhook_message | ||
| self.event.stripe_account = self.stripe_account | ||
| else: | ||
| raise ValueError("The remote account still valid. this might be an hostile event") |
There was a problem hiding this comment.
Pushing to my fork is fine when I don't work on it.
it means I have time to read the notification.
thank you anyway
There was a problem hiding this comment.
Sure. There is --force-with-lease for git-push to only force-push is what you expect it to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't try to fetch the event as we lost access to remote account