Add UniquePerAccountSripeObject for Plans #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
plan-per-account
branch
from
4d45c92
to
f663a8f
Compare
The `stripe_id` for plans is not unique by itself globally (it is not generated by Stripe), and therefore needs to be unique per account.
blueyed
force-pushed
the
plan-per-account
branch
from
f663a8f
to
4d31e12
Compare
Codecov Report
@@ Coverage Diff @@
## next #87 +/- ##
==========================================
+ Coverage 99.08% 99.08% +<.01%
==========================================
Files 34 34
Lines 1857 1861 +4
Branches 173 173
==========================================
+ Hits 1840 1844 +4
Misses 10 10
Partials 7 7
Continue to review full report at Codecov.
|
|
Looks good to me :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stripe_idfor plans is not unique by itself globally (it is not generatedby Stripe), and therefore needs to be unique per account.
Upstream: pinax#513