FilterCollectionTrait - hasActiveFilters method

src/Charcoal/Source/DatabaseSource.php

@@ -925,7 +925,13 @@ public function sqlFilters()
         }
 
         $criteria = $this->createFilter([
-            'filters' => $this->filters()
+            'filters' => array_filter($this->filters(), function ($filter) {
+                // Check for active subfilters
+                if ($filter->hasFilters()) {
+                    return $filter->hasActiveFilters();
+                }
+                return true;
+            })
         ]);
 
         $sql = $criteria->sql();

src/Charcoal/Source/FilterCollectionTrait.php

@@ -127,6 +127,30 @@ public function hasFilters()
         return !empty($this->filters);
     }
 
+    /**
+     * Determine recursively if the object has any active subfilters.
+     *
+     * @return boolean
+     */
+    public function hasActiveFilters()
+    {
+        $endFilters = [];
+
+        // Recusively find filters with no subfilters
+        $this->traverseFilters(function ($filter) use (&$endFilters) {
+            if (!$filter->hasFilters()) {
+                $endFilters[] = $filter;
+            }
+        });
+
+        // Exclude filters that aren't active
+        $endFilters = array_filter($endFilters, function ($filter) {
+            return $filter->active();
+        });
+
+        return !empty($endFilters);
+    }
+
     /**
      * Retrieve the query filters stored in this object.
      *

tests/Charcoal/Source/FilterCollectionTraitTest.php

@@ -119,6 +119,47 @@ public function testHasExpressions()
         $this->assertTrue($obj->hasFilters());
     }
 
+    /**
+     * Test collection for active filters.
+     *
+     * Assertions:
+     * 1. Empty; Default state
+     * 2. Populated; Mutated state
+     * 3. Populated; Added a inactive subfilter
+     *
+     * @covers \Charcoal\Source\FilterCollectionTrait::hasActiveFilters
+     *
+     * @return void
+     */
+    public function testHasActiveExpressions()
+    {
+        $obj = $this->createCollector();
+
+        /** 1. Default state */
+        $this->assertFalse($obj->hasActiveFilters());
+
+        /** 2. Mutated state */
+        $obj->addFilter([
+            'condition' => '( 1 + 1 = 2 )',
+            'filters' => $this->dummyItems,
+        ]);
+
+        $this->assertTrue($obj->hasActiveFilters());
+
+        /** 3. Added a inactive subfilter */
+        $obj->setFilters([[
+            'condition' => '( 1 + 1 = 2 )',
+            'filters' => [
+                [
+                    'condition' => '( 1 + 1 = 2 )',
+                    'active' => false,
+                ]
+            ]
+        ]]);
+
+        $this->assertFalse($obj->hasActiveFilters());
+    }
+
     /**
      * Test the mass assignment of expressions.
      *