Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatabaseSource + Filters - Add Joins, Group By, and BETWEEN filter #12

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

DatabaseSource + Filters - Add Joins, Group By, and BETWEEN filter #12

wants to merge 18 commits into from
+249 −6

Conversation

MouseEatsCat
Copy link

New

  • New Database Filters
    • BETWEEN + NOT BETWEEN
  • New Database Source Options
    • Add options for joins and groupBy clauses

Changed

DatabaseSource::sqlFilters() now checks if subfilters are active or not before including the SQL for them.

MouseEatsCat and others added 16 commits February 16, 2022 10:05
@MouseEatsCat
Add BETWEEN as a filter operator
53eec08
@MouseEatsCat
Adjust formatting
0524bb3
@MouseEatsCat
Add NOT BETWEEN operator
1825bef
@MouseEatsCat
FilterCollection - hasActiveFilters() method
35a854b 
Determine if an object with a filter collection has any active subfilters (recursive)
@MouseEatsCat
DatabaseSource sqlFilters - Filter out inactive filters
5217d04
@MouseEatsCat
Typo - Added missing asterisk in phpdoc
1f1293f
@MouseEatsCat
Apply suggested changes
f635b6f
@MouseEatsCat
Added test for hasActiveFilters()
c2a1e40
@MouseEatsCat
Merge branch 'feature/between-filter' into placeauxjeunes-local
3387105
@MouseEatsCat
Merge branch 'feature/has-active-filters' into placeauxjeunes-local
892d418
@MouseEatsCat
BETWEEN - Add fallback for start + end dates
c4c68e3
@MouseEatsCat
Merge branch 'feature/between-filter' into placeauxjeunes-local
47d680e
@MouseEatsCat
Revert "BETWEEN - Add fallback for start + end dates"
9f0e8c2 
This reverts commit c4c68e3.
@MouseEatsCat
BETWEEN database filter - Throw exception on empty value
2b99ba4
@MouseEatsCat
Merge branch 'feature/between-filter' into placeauxjeunes-local
4ea818e
@MouseEatsCat
DatabaseSource - Add Joins + Group By functionality
912f564
mcaskill
mcaskill requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mcaskill mcaskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding the join methods to CollectionLoader?

src/Charcoal/Source/Database/DatabaseFilter.php Outdated Show resolved Hide resolved
src/Charcoal/Source/Database/DatabaseFilter.php Outdated Show resolved Hide resolved
src/Charcoal/Source/Database/DatabaseFilter.php Outdated Show resolved Hide resolved
src/Charcoal/Source/Database/DatabaseFilter.php Outdated Show resolved Hide resolved
src/Charcoal/Source/Database/DatabaseFilter.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcaskill mcaskill mcaskill approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MouseEatsCat @mcaskill