Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic styleguide page with copy to clipboard js module #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucasBgt
Copy link
Contributor

Little tool to quickly copy-paste DOM elements or others properties from the styleguide page.
For development purposes use only.

@LucasBgt LucasBgt changed the title Basic styleguide page + Copy to clipboard js module Add basic styleguide page with copy to clipboard js module Aug 15, 2022
Copy link
Member

@mcaskill mcaskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest renaming the JS module to Clipboard to match the browser's API.

Maybe rename the HTML data attribute data-copyable-content to data-copyable-text.

Othwerise, this should be a useful starting point until we restart work on the cookbook.

@@ -0,0 +1,82 @@
import { module } from 'modujs'

export default class extends module {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest including a block comment with examples of how to use this module.

Suggested change
export default class extends module {
/**
* Module: NAME
*
* Example of element copying inner HTML:
*
* ```html
* ...
* ```
*
* Example of element copying text from HTML attribute:
*
* ```html
* ...
* ```
*/
export default class extends module {

@arnvvd
Copy link
Contributor

arnvvd commented Oct 5, 2022

Outcome from meeting on 2022-10-05
Status: Changes barring approval

  • Remove javascript
  • Waiting for a solution to disable Sass imports depending on the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants