Fix error percentage cli output #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
raiyankamal
force-pushed
the
fix-error-percentage-cli-output
branch
from
4204c2a
to
54b676c
Compare
The fail percentage was calculated incorrectly. Something that failed all of the time would be reported as failing 50% total.
raiyankamal
force-pushed
the
fix-error-percentage-cli-output
branch
from
54b676c
to
97dc3de
Compare
|
+1 to this, it has fixed the display issue. Please merge :) |
cgoldberg
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up after the conversation in this PR: #1075
Code changes as suggested in disucssion. Requesting review @aldenpeterson-wf @cgoldberg
Added unit tests.
EDIT: force push after removing whitespace changes and rebasing onto latest master.